♻️ Make "go to source definition" work #658
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
coyotte508
force-pushed
the
go-to-source
branch
2 times, most recently
from
c4c3c86 to
8c272d1
Compare
coyotte508
requested review from
mishig25,
xenova,
nsarrazin,
SBrandeis,
osanseviero,
gary149,
Wauplin,
vvmnnnkv and
radames
as code owners
| @@ -25,6 +25,7 @@ export default defineConfig(({ mode }) => { | |||
| emitCss: false, | |||
| compilerOptions: { | |||
| hydratable: true, | |||
| // @ts-expect-error to check cc @krampstudio | |||
There was a problem hiding this comment.
cc @krampstudio , apparently the correct type is Omit<ViteOptions, "generate">, for now bypassed the error (not sure the error is relevant or not)
| "prepublishOnly": "pnpm run build", | ||
| "build": "tsup src/index.ts --format cjs,esm --clean --dts && pnpm run inference-codegen", | ||
| "prepublishOnly": "pnpm run inference-codegen && git diff --name-only --exit-code src && pnpm run build", | ||
| "build": "tsup src/index.ts --format cjs,esm --clean && tsc --emitDeclarationOnly --declaration", |
There was a problem hiding this comment.
@Wauplin @SBrandeis I changed the codegen to automatically run in @huggingface/tasks only during prepublish (publish will error if not up to date)
We would do the same for tgi codegen
It avoids doing it during every pnpm install but should be done manually before publishing (or maybe we could add a lint check that it's up to date in the Lint CI)
|
Going ahead and merging - let me know if any issue arises from it |
|
is the |
good point, updated |
Sorry for all the codeowners reviews
Make "go to source definition" work by using the package, thanks to
.d.ts.mapfiles generated bytsc.Defer type generation to
tscinstead oftsup, sincetsupis not able to generate.d.ts.map. Also removedsharedpackage - since we don't want to publish it, having "go to source" with it would have been problematic. Instead, "shared" files are duplicated between@huggingface/inferenceand@huggingface/hub.Maybe later we can create
@huggingface/webbloband@huggingface/fileblobif we want to reuse them.See also: https://www.npmjs.com/package/dts-buddy used by svelte-kit